size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

View base workflow run

this fixes half of the issue in that it provides proper names for the xhr prototype functions. however, this is still a culprit:

Function.prototype.toString = function() {
    if (this.__sentry_original__) {
        return this.__sentry_original__.toString();
    }
    return origFunctionToString.apply(this);
}

this implementation per se is fine, unfortunately it conflicts with Function.prototype.name - which is not wrapped like this. so i guess this would also need something like

const origFunctionName = Function.prototype.name;
Object.defineProperty(Function.prototype, "name", {
  get() {
    if (this.__sentry_original__) {
      return this.__sentry_original__.name;
    }
    return origFunctionName.apply(this);
  }
});

this is just a poc, not sure if this code works, but that would bring consistency between Function.prototype.toString and Function.prototype.name i guess
edit: just noticed this doesn't work because the name property is not defined on the prototype, but only on the instance. this makes it a bit more difficult to make the behavior consistent...

@DerGernTod makes sense. In your original issue, you're describing a symptom rather than the thing you would like to achieve.

I changed the implementation to be based on proxies. I think that should resolve most if not all of your problems. Can you confirm that?

i tried your changes with our tests and looks like it works fine. nice, thanks!